frank/ruvnet--RuView
1
0
Fork 0
mirror of https://github.com/ruvnet/RuView synced 2026-08-11 20:41:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(homecore): wire plugin lifecycle and preserve MSRV

Browse Source
This commit is contained in:
ruv
2026-07-27 14:30:51 -04:00
parent d8dcccda28
commit 5b5c7f323d
6 changed files with 248 additions and 134 deletions
Download Patch File Download Diff File Expand all files Collapse all files
v2/crates/homecore-plugins/src/discovery.rs
+10 -8
View File
@@ -115,10 +115,7 @@ pub fn discover_plugins(
let manifest_bytes =
bounded_regular_file(&manifest_path, limits.max_manifest_bytes, "manifest")?;
let manifest_text = std::str::from_utf8(&manifest_bytes).map_err(|e| {
PluginError::InvalidManifest(format!(
"{} is not UTF-8: {e}",
manifest_path.display()
))
PluginError::InvalidManifest(format!("{} is not UTF-8: {e}", manifest_path.display()))
})?;
let manifest = PluginManifest::parse_json(manifest_text)?;
if !domains.insert(manifest.domain.clone()) {
@@ -235,9 +232,13 @@ mod tests {
let root = root();
package(&root, "z-last", "zeta", "z.wasm");
package(&root, "a-first", "alpha", "a.wasm");
let found = discover_plugins(&[root.clone()], DiscoveryLimits::default()).unwrap();
let found =
discover_plugins(std::slice::from_ref(&root), DiscoveryLimits::default()).unwrap();
assert_eq!(
found.iter().map(|p| p.manifest.domain.as_str()).collect::<Vec<_>>(),
found
.iter()
.map(|p| p.manifest.domain.as_str())
.collect::<Vec<_>>(),
["alpha", "zeta"]
);
fs::remove_dir_all(root).unwrap();
@@ -247,7 +248,8 @@ mod tests {
fn traversal_module_path_is_rejected() {
let root = root();
package(&root, "bad", "bad", "../bad.wasm");
let error = discover_plugins(&[root.clone()], DiscoveryLimits::default()).unwrap_err();
let error =
discover_plugins(std::slice::from_ref(&root), DiscoveryLimits::default()).unwrap_err();
assert!(matches!(error, PluginError::InvalidManifest(_)));
fs::remove_dir_all(root).unwrap();
}
@@ -257,7 +259,7 @@ mod tests {
let root = root();
package(&root, "large", "large", "large.wasm");
let error = discover_plugins(
&[root.clone()],
std::slice::from_ref(&root),
DiscoveryLimits {
max_module_bytes: 4,
..DiscoveryLimits::default()
v2/crates/homecore-plugins/src/tests.rs
+9 -2
View File
@@ -5,6 +5,7 @@
//! and PluginError variants.
#[cfg(test)]
#[allow(clippy::module_inception)]
mod tests {
use std::sync::Arc;
@@ -144,7 +145,10 @@ mod tests {
.expect("load should succeed");
assert_eq!(id.as_str(), "lights");
assert!(*plugin.setup_called.lock().await, "setup should have been called");
assert!(
*plugin.setup_called.lock().await,
"setup should have been called"
);
let listing = registry.list().await;
assert_eq!(listing.len(), 1);
@@ -163,7 +167,10 @@ mod tests {
.expect("load should succeed");
registry.unload(&id).await.expect("unload should succeed");
assert!(*plugin.unload_called.lock().await, "unload should have been called");
assert!(
*plugin.unload_called.lock().await,
"unload should have been called"
);
assert_eq!(registry.list().await.len(), 0);
}