mirror of
https://github.com/ruvnet/RuView
synced 2026-07-24 17:43:20 +00:00
Dragan Spiridonov
3ed43e9a2f
Three coupled defects, all found by building the wheel and running the real
suite on Apple Silicon rather than trusting green CI.
1. THE P6 SOTA BINDINGS NEVER REACHED USERS (release blocker).
`pip-release.yml`'s cibuildwheel built the DEFAULT feature set, so published
wheels contained none of aether/mat/meridian. `pip install
wifi-densepose[aether]` then raised ImportError — and the extra is empty, so
its own error message ("install the [aether] extra") sent users in a circle.
A pip extra cannot enable a Rust cargo feature on an already-built wheel, so
the only way P6 reaches PyPI is to compile it in.
Fix: the RELEASE build opts in via `MATURIN_PEP517_ARGS="--features sota"`
(per-platform, since CIBW_ENVIRONMENT_LINUX overrides CIBW_ENVIRONMENT).
`default = []` in Cargo.toml, the RuView#1387-default-wheel-budget-config
fix-marker, and the wheel-size-budget job are all left UNTOUCHED — they keep
guarding the small base compile. Measured published wheel: 1.68 MiB, well
under the ADR-117 §5.4 5 MiB budget. Proven: built via the exact PEP517 path,
`import wifi_densepose.aether/mat/meridian` all succeed.
2. THE WHEEL SMOKE TEST COULD NOT SEE #1.
CIBW_TEST_COMMAND only asserted `hello()` and PRINTED `__build_features__`.
The one signal that would reveal missing bindings was dumped to stdout and
ignored, so a featureless wheel published green. It now ASSERTS the p6
features are present and imports the three modules. Proven red→green: fails
on the old featureless wheel ("missing SOTA bindings: [...]"), passes on the
fixed one.
3. THE AETHER PARITY TESTS WERE NOT PORTABLE ACROSS THE WHEEL MATRIX.
`test_aether.py` and the native `aether_parity.rs`/`aether_weights_parity.rs`
hashed the raw f32 embedding bytes (SHA-256) against a committed golden. The
embedding is pure f32 with transcendental ops (ln/sqrt/cos) that are not
bit-reproducible across CPUs/libm, so the hash only ever matched the one arch
that generated it. This passed in python-ci (x86) but fails on the aarch64 /
macOS-arm wheels this same project ships — latent until #1 is fixed and the
bindings actually load. Every tolerance/behavioral assertion already passed;
only the two byte-hash tests failed, which is the signature of a non-portable
golden, not a logic bug.
Fix: compare to a committed golden VECTOR within tolerance
(atol=rtol=1e-4 — ~100x cross-arch f32 drift, ~100x under any real algorithm
change), on both the Python and native sides against the SAME golden. Native
≈ golden and binding ≈ golden together prove binding ≈ native, portably.
`.sha256` goldens replaced by `.json` vectors.
Also: the aether/mat/meridian import shims told users to `pip install
wifi-densepose[<x>]` on a missing feature — an empty extra that cannot help.
Corrected to name the real fix (rebuild with `--features <x>`); message tests
updated to assert the honest message and forbid the misleading one.
Verified on aarch64/macOS: full `python/tests/` suite 227 passed against a wheel
built with the new mechanism; `cargo check --tests --features aether` clean.
The native `.rs` parity tests were converted by inspection and cargo-checked but
not executed — they link against the PyO3 crate and no workflow runs them today
(a pre-existing gap; wiring `cd python && cargo test --features sota` into
python-ci would make the native anchor actually run).
Co-Authored-By: Ruflo & AQE
62 lines
2.4 KiB
Python
62 lines
2.4 KiB
Python
"""MERIDIAN — cross-environment domain generalization (ADR-027, ADR-185 P2).
|
|
|
|
Hardware-invariant CSI normalization, geometry-conditioned deployment,
|
|
few-shot room adaptation, and cross-domain evaluation — the tch-free
|
|
inference/adaptation path of Project MERIDIAN, computed by the Rust core.
|
|
|
|
Included in the official ``wifi-densepose`` wheels. It is absent only from a
|
|
from-source build that did not enable the Rust ``meridian`` feature; rebuild with
|
|
``maturin ... --features meridian`` (or ``--features sota``) in that case.
|
|
|
|
Quick start::
|
|
|
|
from wifi_densepose.meridian import HardwareNormalizer, HardwareType
|
|
|
|
norm = HardwareNormalizer() # canonical 56 subcarriers
|
|
hw = HardwareType.detect(64) # -> HardwareType.Esp32S3
|
|
frame = norm.normalize(amplitude, phase, hw) # -> CanonicalCsiFrame
|
|
print(len(frame.amplitude), frame.hardware_type)
|
|
|
|
Note (honest scope, ADR-185 §3.3): the ADR's ``RapidAdaptation.calibrate``
|
|
/ ``AdaptationResult.converged`` do not exist in the Rust core — use
|
|
``push_frame(...)`` then ``adapt()``; the result exposes ``final_loss``,
|
|
``frames_used``, ``adaptation_epochs``. Training-time types
|
|
(DomainFactorizer, GradientReversalLayer, VirtualDomainAugmentor) are
|
|
out of scope for P6 (they need the deferred libtorch training tier).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from wifi_densepose import _native
|
|
|
|
# MERIDIAN symbols are compiled into `_native` only under the Rust
|
|
# `meridian` feature; absent in a base wheel (ADR-185 §6 acceptance).
|
|
if not hasattr(_native, "HardwareNormalizer"):
|
|
raise ImportError(
|
|
"wifi_densepose.meridian is not available in this build. The official "
|
|
"wheels include it; if you built from source, rebuild with "
|
|
"`maturin ... --features meridian` (or `--features sota`)."
|
|
)
|
|
|
|
HardwareType = _native.HardwareType
|
|
CanonicalCsiFrame = _native.CanonicalCsiFrame
|
|
HardwareNormalizer = _native.HardwareNormalizer
|
|
MeridianGeometryConfig = _native.MeridianGeometryConfig
|
|
GeometryEncoder = _native.GeometryEncoder
|
|
RapidAdaptation = _native.RapidAdaptation
|
|
AdaptationResult = _native.AdaptationResult
|
|
CrossDomainEvaluator = _native.CrossDomainEvaluator
|
|
mpjpe = _native.mpjpe
|
|
|
|
__all__ = [
|
|
"HardwareType",
|
|
"CanonicalCsiFrame",
|
|
"HardwareNormalizer",
|
|
"MeridianGeometryConfig",
|
|
"GeometryEncoder",
|
|
"RapidAdaptation",
|
|
"AdaptationResult",
|
|
"CrossDomainEvaluator",
|
|
"mpjpe",
|
|
]
|