mirror of
https://github.com/ruvnet/RuView
synced 2026-08-07 20:01:43 +00:00
42dcf49f4d
* fix(signal): circular phase variance for ghost-tap guard (ADR-154 §7.4 #1) `phase_variance` computed a LINEAR sample variance over phase angles that wrap at ±π, so a tightly-clustered set straddling the branch cut reported spuriously HIGH dispersion — false-tripping the `> TAU` ghost-tap guard on real, tightly-clustered CIR taps. Replace with Mardia's circular variance V = 1 − R̄, bounded [0,1] and invariant to where the cluster sits on the circle. Re-derive the guard against the bounded metric via a named const `GHOST_TAP_CIRCULAR_VARIANCE_MAX` (the old TAU-scaled threshold is meaningless on [0,1]). Grade: metric fix MEASURED; threshold value DATA-GATED — a clean single-path ramp also sweeps the circle, so V alone cannot separate clean from unsanitized without labelled frames. Conservative default (0.99) errs toward never false-rejecting, strictly more permissive at the wrap boundary than the buggy linear guard. Fails-on-old test: `phase_variance_circular_not_fooled_by_branch_cut` — inlines the old linear variance to show it exceeds TAU on wrap-straddling phases while circular V≈0 and the guard no longer trips. Plus `phase_variance_circular_is_bounded_and_extremal` (V∈[0,1], V≈0 identical, V≈1 uniform). cargo test -p wifi-densepose-signal --no-default-features --features cir --lib → 432 passed, 0 failed. Co-Authored-By: claude-flow <ruv@ruv.net> * fix(signal): pin Welford n=0/n=1 finiteness guard (ADR-154 §7.4 #10) The shared `WelfordStats` (field_model.rs, used by longitudinal.rs and others) relies on `count < 2` guards in `variance`/`sample_variance`/`std_dev`/ `z_score` to stay finite at the boundaries. The guards existed but the n=0 boundary was UNTESTED — exactly the §4 divide-by-(n−1) family the ADR groups this with. Add `welford_finite_at_n0_and_n1` asserting every statistic is finite and returns the documented sentinel (0.0) at n=0 and n=1, plus load-bearing doc comments on the two guards. Fails-on-old proof: with the `sample_variance` guard removed, the test FAILS with "attempt to subtract with overflow" at the `(self.count - 1)` underflow (0usize − 1); `variance` would similarly yield 0.0/0.0 = NaN. The guard is restored; the test pins it so a future regression is caught. Grade: MEASURED (boundary finiteness is asserted; the guard is the §4-family fix made testable). cargo test -p wifi-densepose-signal --no-default-features --lib field_model → 22 passed, 0 failed. Co-Authored-By: claude-flow <ruv@ruv.net> * refactor(signal): de-magic adversarial thresholds + boundary tests (ADR-154 §7.4 #13) Lift the bare numeric literals buried in `check`/`check_consistency` into named, documented module consts (FIELD_MODEL_GINI_VIOLATION=0.8, ENERGY_RATIO_HIGH_VIOLATION=2.0, ENERGY_RATIO_LOW_VIOLATION=0.1, CONSISTENCY_ACTIVE_FRACTION_OF_MEAN=0.1, SCORE_W_* weights). VALUES UNCHANGED — each const equals the original literal; only names + pinning tests are new. Grade: DATA-GATED. The operating values stay empirical (defensible values need labelled spoofed/clean CSI — Wi-Spoof, §6.2/§7.3). The de-magicking + characterization tests are MEASURED: `tuning_consts_unchanged_from_literals`, `energy_ratio_high_boundary`, `energy_ratio_low_boundary`, `field_model_gini_boundary`, `consistency_active_fraction_boundary` pin the decision boundaries at/just-below/just-above each threshold, so a future data-driven retune is a visible, tested change. Fails-on-change proof: bumping ENERGY_RATIO_HIGH_VIOLATION 2.0→3.0 makes `energy_ratio_high_boundary` FAIL (restored). Operating values explicitly NOT changed. cargo test -p wifi-densepose-signal --no-default-features --lib ruvsense::adversarial → 20 passed, 0 failed. Co-Authored-By: claude-flow <ruv@ruv.net> * refactor(signal): de-magic coherence drift/gate thresholds (ADR-154 §7.4 #9) Lift the bare detection literals in `coherence.rs::classify_drift` (DRIFT_STABLE_SCORE=0.85, DRIFT_STEP_CHANGE_MAX_STALE=10) and the `coherence_gate.rs` Default impl (DEFAULT_ACCEPT_THRESHOLD=0.85, DEFAULT_REJECT_THRESHOLD=0.5, DEFAULT_MAX_STALE_FRAMES=200, DEFAULT_PREDICT_ONLY_NOISE=3.0) into named, documented consts. VALUES UNCHANGED. The gate already exposed these via GatePolicyConfig (config seam); this names + pins the defaults. Grade: DATA-GATED. Operating values stay empirical (defensible Z-score thresholds need labelled stable/drifting coherence traces). De-magicking + boundary tests are MEASURED: `classify_drift_stable_score_boundary`, `classify_drift_stale_count_boundary` pin the at/just-below/just-above decisions; `drift_consts_unchanged_from_literals` / `gate_default_consts_unchanged_from_literals` pin the values. Operating values explicitly NOT changed. cargo test -p wifi-densepose-signal --no-default-features --lib ruvsense::coherence → 40 passed, 0 failed. Co-Authored-By: claude-flow <ruv@ruv.net> * docs(adr-154): mark §7.4 P1 backlog cleared — Milestone-1 (#1,#10 RESOLVED; #9,#13 DATA-GATED) Update ADR-154 §7.4 backlog rows #1, #9, #10, #13 with commit refs + grades, the §7.4 intro count (four P1 items cleared, ~41 P2/P3 remain), the Horizon-ledger one-liner (Milestone-1 DONE), and the §8 honest-limits #1 line (metric now correct; threshold still DATA-GATED). Add CHANGELOG [Unreleased] entry. Grades: #1 RESOLVED (MEASURED metric / DATA-GATED threshold), #10 RESOLVED (MEASURED), #9 & #13 RESOLVED-PARTIAL (DATA-GATED — de-magicked + boundary tested, operating values unchanged). Validation: cargo test --workspace --no-default-features → 2057 passed, 0 failed; wifi-densepose-signal lib → 442 passed (no-default + --features cir); python archive/v1/data/proof/verify.py → VERDICT: PASS, hash f8e76f21…46f7a UNCHANGED (CIR ghost-tap guard is not on the deterministic proof path). Co-Authored-By: claude-flow <ruv@ruv.net> * fix(sensing-server): stop leaking internal errors in HTTP responses (ADR-080 #2) Six handlers in `main.rs` serialized the internal error `Display` straight into the JSON response body, leaking server internals to any client (ADR-080 finding #2, CWE-209; reframed onto the Rust boundary by ADR-164 G11): - edge_registry_endpoint: a panicked spawn_blocking `JoinError` ("task … panicked") in a 500, and the raw upstream error in a 503 - delete_model / delete_recording / start_recording: std::io::Error strings carrying OS detail / filesystem paths - calibration_start / calibration_stop: the FieldModel error chain New `error_response` module: `internal_error` / `internal_error_json` / `upstream_unavailable` log the full detail server-side only (tagged with a correlation id) and return a generic body (`{"error":"internal_error","correlation_id":…}`) — no `panicked`, no file paths, no Debug chain. The correlation id lets an operator join a client report to the exact server log line without ever shipping the detail. Pinned by 5 error_response tests, incl. a leak-substring guard (internal_error_body_does_not_leak_detail) verified to FAIL on the reverted old body (returns the panic message / path / "os error"). The HOMECORE sweep (ADR-161) covered homecore-server, not this crate. Co-Authored-By: claude-flow <ruv@ruv.net> * test(sensing-server): pin XFF-immunity + no-query-token (ADR-080 #1, #3) Findings #1 (XFF-spoofing bypass) and #3 (JWT-in-URL, CWE-598) were logged against the Python v1 API but are VERIFIED ABSENT on the current Rust sensing-server, so they get regression tests rather than redundant fixes: - #1 XFF: there is no IP-based rate-limiter or IP-allowlist to bypass, and neither security middleware reads a forwarded header. Added bearer_auth::xff_header_never_affects_auth_decision (spoofed X-Forwarded-For never flips a 401<->200 decision) and host_validation::forwarded_headers_never_bypass_host_allowlist (spoofed X-Forwarded-Host: localhost never lets Host: evil.com past the allowlist). - #3 JWT-in-URL: require_bearer reads the token only from the Authorization header; WS handlers take no query token; the sole Query extractor (EdgeRegistryParams) is a non-secret refresh flag. Added bearer_auth::query_string_token_is_never_accepted — ?token= / ?access_token= in the URL never authenticates (stays 401) while the header path still 200s. Verified to FAIL when a query-token path is injected into require_bearer. Co-Authored-By: claude-flow <ruv@ruv.net> * docs(adr-080): mark P0 security findings #1-#3 RESOLVED; close ADR-164 G11 - ADR-080: Status note + per-finding closure (#1 XFF and #3 JWT-in-URL verified absent + regression-pinned; #2 leaked errors fixed via the error_response module). Records the v1-vs-Rust boundary distinction explicitly: v1 paths remain archived; this closure governs the shipped Rust sensing-server. - ADR-164: Gap Register G11 and the Open/Gated Backlog entry marked RESOLVED with the fix + branch reference. - CHANGELOG: [Unreleased] -> ### Security entry covering all three findings. Co-Authored-By: claude-flow <ruv@ruv.net> * docs(adr): renumber 6 displaced ADRs to resolve duplicate-number collisions (ADR-164 G1) Resolves the 5 duplicate ADR numbers (6 displaced files) flagged by ADR-164 Gap Register item G1. Canonical keeper per number = first file committed at that number (date tie-broken by inbound cross-reference count / parent-appendix relationship). Displaced files renumbered to the next free numbers (166-171): 050 keeps provisioning-tool-enhancements (5 refs vs 1) -> ADR-166-quality-engineering-security-hardening 052 keeps tauri-desktop-frontend (parent ADR) -> ADR-167-ddd-bounded-contexts (its appendix) 147 keeps nvidia-cosmos/OccWorld (the actual ADR, has Status header) -> ADR-168-benchmark-proof (proof companion, no Status) -> ADR-169-adam-mode-light-theme (was untracked) 148 keeps drone-swarm-control-system (committed #862) -> ADR-170-yoga-mode-pose-system (was untracked) 149 keeps public-community-leaderboard-huggingface (committed 16:47 vs 17:38) -> ADR-171-swarm-benchmarking-evaluation-methodology Updates in-file `# ADR-NNN` headers and intra-file self-references (yoga-modes * docs(adr): repoint inbound cross-references to renumbered ADRs (166-171) Follow-up to the ADR renumbering (ADR-164 G1). Updates every inbound reference that pointed at a displaced ADR, disambiguating shared numbers by title/slug so only references to the DISPLACED topic move and keeper references stay put. ADR-168 (was 147 benchmark-proof): README, CHANGELOG, user-guide, proof-of-capabilities, research docs 00/03 — all path/label refs updated. ADR-169 (was 147 adam-mode) / ADR-170 (was 148 yoga-mode): docs/adr/README index. ADR-171 (was 149 swarm-benchmarking): all ruview-swarm eval code+docs (Cargo.toml, evals/, eval_swarm.rs, metrics/mod/report/runner.rs), research doc 03 (every §-ref matched ADR-171 sections, not AetherArena), 00-system-review, series README, CHANGELOG, and ADR-148's forward/"open issues" pointers. ADR-166 (was 050 quality-engineering / security-hardening): disambiguated from the ADR-050 provisioning KEEPER by topic. The HMAC/secure_tdm, directory-traversal, bind-address, and OTA-PSK-auth references in code comments (wifi-densepose-hardware Cargo.toml + secure_tdm.rs, sensing-server main.rs) and in ADR-052-tauri / ADR-167 all describe the security-hardening ADR -> ADR-166. ADR-167 (was 052 ddd-appendix): inbound appendix references. Index/registry updates: docs/adr/README.md, gap-analysis/census.md (rows + header count), gap-analysis/lens-findings.md (collision table marked RESOLVED), and ADR-164 Gap Register G1 marked RESOLVED with the full renumber map. Keeper references deliberately untouched: all ADR-147 OccWorld code, all ADR-148 drone-swarm code/docs, all ADR-149 AetherArena refs (incl. ADR-150's SSL/resampling refs, which ADR-150 explicitly binds to the AetherArena benchmark), ADR-050 provisioning refs, ADR-052 tauri refs. The frozen GitHub blob URLs in docs/adr/.issue-177-body.md (pinned to an old branch) are left as historical. Comment-only code edits; no behavior change. wifi-densepose-hardware compiles clean; the sensing-server build's sole blocker is the pre-existing upstream midstreamer-temporal-compare@0.2.1 registry crate, unrelated to these edits. Co-Authored-By: claude-flow <ruv@ruv.net>
151 lines
5.1 KiB
Rust
151 lines
5.1 KiB
Rust
//! Per-episode and aggregate SAR + MARL metrics (ADR-171 Stage 1).
|
||
|
||
use crate::evals::stats::{stratified_bootstrap_ci, ConfidenceInterval};
|
||
|
||
/// Per-episode SAR metrics (Stage 1 kinematic).
|
||
#[derive(Debug, Clone)]
|
||
pub struct EpisodeMetrics {
|
||
/// Fraction of the mission area scanned at least once, in [0, 1].
|
||
pub coverage_pct: f64,
|
||
/// Localization error (m) of the fused victim estimate; `None` if no detection.
|
||
pub localization_error_m: Option<f64>,
|
||
/// GDOP of the contributing-drone constellation at detection; `None` if none.
|
||
pub gdop_at_detection: Option<f64>,
|
||
/// Mission-elapsed seconds to first detection; `None` if no detection.
|
||
pub time_to_first_detection_s: Option<f64>,
|
||
/// Whether at least one victim was detected this episode.
|
||
pub detected: bool,
|
||
/// Count of inter-drone proximity violations (kinematic proxy for collisions).
|
||
pub collisions: u32,
|
||
/// Fraction of scanned area covered by more than one drone, in [0, 1].
|
||
pub overlap_ratio: f64,
|
||
/// Scalar episodic return (reward-like coverage/detection objective).
|
||
pub episodic_return: f64,
|
||
}
|
||
|
||
/// Aggregate over a seed × episode matrix with IQM + 95% bootstrap CIs.
|
||
#[derive(Debug, Clone)]
|
||
pub struct AggregateMetrics {
|
||
pub coverage_iqm: ConfidenceInterval,
|
||
/// IQM over detected episodes only (undetected episodes carry no error).
|
||
pub localization_iqm: ConfidenceInterval,
|
||
pub detection_rate: f64,
|
||
pub mean_gdop: f64,
|
||
pub return_iqm: ConfidenceInterval,
|
||
pub n_episodes: usize,
|
||
}
|
||
|
||
impl AggregateMetrics {
|
||
/// Aggregate a seed-stratified matrix of episodes. Each inner `Vec` is one
|
||
/// seed's episodes; bootstrap resampling is stratified by seed so the CI
|
||
/// reflects between-seed variance (the dominant source per ADR-171).
|
||
pub fn from_strata(per_seed: &[Vec<EpisodeMetrics>], boot_seed: u64) -> Self {
|
||
const N_BOOT: usize = 1000;
|
||
|
||
let coverage_strata: Vec<Vec<f64>> = per_seed
|
||
.iter()
|
||
.map(|s| s.iter().map(|e| e.coverage_pct).collect())
|
||
.collect();
|
||
let return_strata: Vec<Vec<f64>> = per_seed
|
||
.iter()
|
||
.map(|s| s.iter().map(|e| e.episodic_return).collect())
|
||
.collect();
|
||
// Localization: only detected episodes contribute. Keep stratification
|
||
// by seed but drop empty strata so the bootstrap doesn't degenerate.
|
||
let loc_strata: Vec<Vec<f64>> = per_seed
|
||
.iter()
|
||
.map(|s| {
|
||
s.iter()
|
||
.filter_map(|e| e.localization_error_m)
|
||
.collect::<Vec<f64>>()
|
||
})
|
||
.filter(|v: &Vec<f64>| !v.is_empty())
|
||
.collect();
|
||
|
||
let mut detected = 0usize;
|
||
let mut total = 0usize;
|
||
let mut gdop_sum = 0.0;
|
||
let mut gdop_n = 0usize;
|
||
for seed in per_seed {
|
||
for e in seed {
|
||
total += 1;
|
||
if e.detected {
|
||
detected += 1;
|
||
}
|
||
if let Some(g) = e.gdop_at_detection {
|
||
if g.is_finite() {
|
||
gdop_sum += g;
|
||
gdop_n += 1;
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
let detection_rate = if total == 0 {
|
||
0.0
|
||
} else {
|
||
detected as f64 / total as f64
|
||
};
|
||
let mean_gdop = if gdop_n == 0 {
|
||
0.0
|
||
} else {
|
||
gdop_sum / gdop_n as f64
|
||
};
|
||
|
||
AggregateMetrics {
|
||
coverage_iqm: stratified_bootstrap_ci(&coverage_strata, N_BOOT, boot_seed),
|
||
localization_iqm: stratified_bootstrap_ci(
|
||
&loc_strata,
|
||
N_BOOT,
|
||
boot_seed.wrapping_add(1),
|
||
),
|
||
detection_rate,
|
||
mean_gdop,
|
||
return_iqm: stratified_bootstrap_ci(
|
||
&return_strata,
|
||
N_BOOT,
|
||
boot_seed.wrapping_add(2),
|
||
),
|
||
n_episodes: total,
|
||
}
|
||
}
|
||
}
|
||
|
||
#[cfg(test)]
|
||
mod tests {
|
||
use super::*;
|
||
|
||
fn ep(cov: f64, loc: Option<f64>, ret: f64, detected: bool) -> EpisodeMetrics {
|
||
EpisodeMetrics {
|
||
coverage_pct: cov,
|
||
localization_error_m: loc,
|
||
gdop_at_detection: if detected { Some(2.0) } else { None },
|
||
time_to_first_detection_s: if detected { Some(10.0) } else { None },
|
||
detected,
|
||
collisions: 0,
|
||
overlap_ratio: 0.1,
|
||
episodic_return: ret,
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn test_aggregate_detection_rate_and_shape() {
|
||
let per_seed = vec![
|
||
vec![
|
||
ep(0.8, Some(1.5), 80.0, true),
|
||
ep(0.7, None, 70.0, false),
|
||
],
|
||
vec![
|
||
ep(0.9, Some(2.0), 90.0, true),
|
||
ep(0.85, Some(1.0), 85.0, true),
|
||
],
|
||
];
|
||
let agg = AggregateMetrics::from_strata(&per_seed, 7);
|
||
assert_eq!(agg.n_episodes, 4);
|
||
assert!((agg.detection_rate - 0.75).abs() < 1e-9);
|
||
assert!(agg.coverage_iqm.lo <= agg.coverage_iqm.point);
|
||
assert!(agg.coverage_iqm.point <= agg.coverage_iqm.hi);
|
||
assert!(agg.mean_gdop > 0.0);
|
||
}
|
||
}
|